Makefile: allow injecting prebuilt thrift compiler - #617
Closed
lf- wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for fb-oss-glean canceled.
|
meta-cla
Bot
added
the
CLA Signed
lf-
force-pushed
the
jade/push-snyrskmvstyy
branch
2 times, most recently
from
November 21, 2025 22:00
49787c6 to
3fce580
Compare
Collaborator
|
LGTM |
lf-
force-pushed
the
jade/push-snyrskmvstyy
branch
2 times, most recently
from
December 10, 2025 19:13
67c7866 to
165a2d9
Compare
lf-
force-pushed
the
jade/push-snyrskmvstyy
branch
from
January 7, 2026 15:41
165a2d9 to
d32b999
Compare
This is required for Nix builds. I also switched pwd to be resolved from PATH because /bin/pwd is not a thing on NixOS.
lf-
force-pushed
the
jade/push-snyrskmvstyy
branch
from
January 20, 2026 19:43
d32b999 to
561fb0a
Compare
lf-
added a commit
to MercuryTechnologies/hsthrift
that referenced
this pull request
Jan 21, 2026
There are a couple of problems this fixes: - assuming that the thrift compiler comes from this build. This is not true in Nix: we are going to build each package separately. - assuming that folly-clib versions need to be fiddled with. This is not necessary for Nix as we are provisioning an entirely-external folly. This mirrors the same changes as facebookincubator/Glean#617.
lf-
added a commit
to MercuryTechnologies/hsthrift
that referenced
this pull request
Jan 23, 2026
There are a couple of problems this fixes: - assuming that the thrift compiler comes from this build. This is not true in Nix: we are going to build each package separately. - assuming that folly-clib versions need to be fiddled with. This is not necessary for Nix as we are provisioning an entirely-external folly. This mirrors the same changes as facebookincubator/Glean#617.
Contributor
|
@aahanaggarwal has imported this pull request. If you are a Meta employee, you can view this in D93098872. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for Nix builds.
I also switched pwd to be resolved from PATH because /bin/pwd is not a thing on NixOS.